[gmp] Fix building for linux x86 #31339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Easyflex" |
Cheney-W
added
the
category:community-triplet
dg0yt
reviewed
May 9, 2023
Comment on lines
+68
to
+71
| elseif(VCPKG_TARGET_IS_LINUX AND VCPKG_TARGET_ARCHITECTURE STREQUAL "x86") | ||
| set(ccas "${VCPKG_DETECTED_CMAKE_C_COMPILER}") | ||
| vcpkg_list(APPEND OPTIONS "ABI=32") | ||
| string(APPEND asmflags " -m32") |
There was a problem hiding this comment.
I have recently seen/used the same x86 pattern in another port but for Android.
- Do we really need
ABI=32in addition to-m32? - Which other x86 toolchains/triplets will understand
-m32? - Can we get
-m32from the cmake toolchain?
There was a problem hiding this comment.
ABI=32 is required, fixes:
configure: error: Oops, mp_limb_t is 32 bits, but the assembler code
in this configuration expects 64 bits.
You appear to have set $CFLAGS, perhaps you also need to tell GMP the
intended ABI, see "ABI and ISA" in the manual.
The -m32 is also necessary, without it, compile of asm fails:
tmp-add_n.s: Assembler messages:
tmp-add_n.s:202: Error: operand type mismatch for `jmp'
make[2]: *** [add_n.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
tmp-sub_n.s: Assembler messages:
tmp-sub_n.s:202: Error: operand type mismatch for `jmp'
make[2]: *** [sub_n.lo] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
There was a problem hiding this comment.
If you need asm flags you might want to actually request it from vcpkg_get_cmake_vars.
There was a problem hiding this comment.
Unfortunately, vcpkg_cmake_get_vars isn't taking parameters such as LANGUAGES ATM. (And maybe it should be handled gracefully if ASM can't be enabled.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.